Fix incorrect state update following NSX error #1138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When QoS profile resource is updated with incorrect value that NSX rejects, the value would still get updated in the state, even though Update returned an error.
This is terraform SDK bug:
hashicorp/terraform-plugin-sdk#476
This change implements the suggested workaround.
We should consider to always implement this workaround as part of
handleUpdateError
, however first it would help to understand why this problem appears only for certain resources.